docs: websockets do not work with vite dev server pre-Deno 2.8 and Fresh 2.4#3822
Merged
Merged
Conversation
Contributor
|
This is expected to work with Deno V2.8: https://deno.com/blog/v2.8#miscellaneous |
Contributor
Author
|
@bartlomieju thanks for the quick response! Hm, I am running deno 2.8 and yet I still appear to be encountering this issue. |
Contributor
|
Good catch, I forgot about a counterpart needed in Fresh. I opened #3823 to fix that and will do a 2.4 release afterwards. |
bartlomieju
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the docs to reflect the fact that upgrading websocket requests isn't currently supported by the vite dev server.
This cost me some time as there isn't any warning in the console on the server, the upgrade request merely hangs. Perhaps that could be fixed as well, but this update to the docs (while verbose) would document the behavior.